1040068 - Inconsistency in [contacts] buttons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Contacts buttons regressed after landing bug 1036147

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: after_patch.png

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: bug.png

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8457991 [details] [review]
patch in github

Francisco, changing reviewer to Jose Manuel after talking to him.
Let's try to fix that quickly :)

Comment 5

[Jose Manuel Cantera]

Comment on attachment 8457991 [details] [review]
patch in github

thanks Arnau

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Landing since we have r+ and gaia-try is green :)

Thanks a lot Arnau!!

Landed on master:

https://github.com/rnowm/gaia/commit/7a6adf9963a6a929631a8c8a4831733d034e2f94

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5b5695f6a24ea9fb1a4a92cb647c50991ac49588

Comment 9

[Paladin]

Hi Aranu,
Could you please provide the detailed reproduce steps for me to verify this bug? :)

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

please check the images to see what happened before the bug:
https://bug1040068.bugzilla.mozilla.org/attachment.cgi?id=8457995
and after fixing it:
https://bug1040068.bugzilla.mozilla.org/attachment.cgi?id=8457993

STR:
1. Open contacts app
2. tap on an existing contact
3. the attached screen will appear (contact details)

Comment 11

[Paladin]

Thank you, Arnau.
This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_image.png
Reproducing rate: 0/5
FLame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0

Comment 12

[Paladin]

Attachment: Verify_image.png